Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polar): polar bar animation should start from r0 rather than 0 #17997

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Nov 30, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix polar bar initial animation starting from the center of the polar circle rather than r0 position.

Fixed issues

Details

Before: What was the problem?

When polar.radius is like [50, 150], the polar bar starts from the center of the polar.

After: How does it behave after the fixing?

When polar.radius is like [50, 150], the polar bar starts from circle with radius 50.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 30, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.5.0 milestone Nov 30, 2022
@Ovilia Ovilia merged commit 02d11cd into master Dec 1, 2022
@Ovilia Ovilia deleted the fix-polar-animation branch December 1, 2022 01:48
@echarts-bot
Copy link

echarts-bot bot commented Dec 1, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants