Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EChartsInitOpts type error about height and width. close #17667 #17727

Merged
merged 1 commit into from
Oct 8, 2022
Merged

fix: EChartsInitOpts type error about height and width. close #17667 #17727

merged 1 commit into from
Oct 8, 2022

Conversation

YuShengHou
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix type error about height and width of EChartsInitOpts

Fixed issues

#17667

Details

Before: What was the problem?

[Bug] The documentation for EChartsInitOpts has a type error about height and width

The description type of the document differs from that in the code
image
image

After: How does it behave after the fixing?

Add union types number | string for height and width

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 5, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@YuShengHou YuShengHou changed the title fix: #17667 EChartsInitOpts type error about height and width fix: EChartsInitOpts type error about height and width. close #17667 Oct 5, 2022
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the definition in ZRender, this change should be correct.

@Ovilia Ovilia merged commit db0f92a into apache:master Oct 8, 2022
@echarts-bot
Copy link

echarts-bot bot commented Oct 8, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants