-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(marker): fix markArea
doesn't show when using x/y
pixel but coord
is not defined
#17217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
Ovilia
requested changes
Sep 23, 2022
plainheart
changed the title
fix: fix the error caused by setting markArea x/y
fix(marker): fix Nov 10, 2022
markArea
doesn't show when using x/y
pixel but coord
is not defined
Ovilia
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the error that occurs when declaring area with x/y in
markArea
Fixed issues
Details
Before: What was the problem?
As is described in issues, when setting x and y to denote an area for
markArea
, the error occurs. This is caused becasuelt
andrb
returned bydataTransform()
has no attributecoord
when user does not specifycoord
inmarkArea.data
. So when running the following code, Echarts readslt.coord
and throw an error.echarts/src/component/marker/MarkAreaView.ts
Lines 69 to 79 in 11a9247
After: How does it behave after the fixing?
Now before
dataTransform()
return anitem
, a check is added and make sure there's acoord
attribute in it (evencoord
is not needed). And there will be no errors caused by this.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information