You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the interface PictorialBarSeriesOption extends the interface SeriesEncodeOptionMixin .
Fixed issues
No issues.
Details
Before: What was the problem?
The interface PictorialBarSeriesOption don't extends interface SeriesEncodeOptionMixin.
But PictorialBar supports the config encode as document describled.
So,this PR was produced to improve the definition of PictorialBar.
After: How is it fixed in this PR?
Let the interface PictorialBarSeriesOption extends interface SeriesEncodeOptionMixin .
Misc
The API has been changed (apache/echarts-doc#xxx).
This PR depends on ZRender changes (ecomfe/zrender#xxx).
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Please squash the commits into a single one when merging.
I check the code and the following series don't have SeriesEncodeOptionMixin. @100pah Can you confirm if there are any missing by mistake?
Treemap
Tree
Sunburst
Lines
Graph
Sankey
ThemeRiver
Pictorial (the only one that has encode in the doc)
Tree based data source (Treemap, Tree, Sunburst) and graph based data source (Graph, Sankey ) theoretically can use encode, but we might not ready to use it (e.g., no test case yet).
Lines and ThemeRiver have special data source, which we are not sure whether it is suitable to use encode yet.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Let the interface PictorialBarSeriesOption extends the interface SeriesEncodeOptionMixin .
Fixed issues
No issues.
Details
Before: What was the problem?
The interface PictorialBarSeriesOption don't extends interface SeriesEncodeOptionMixin.
But PictorialBar supports the config
encodeas document describled.So,this PR was produced to improve the definition of PictorialBar.
After: How is it fixed in this PR?
Let the interface PictorialBarSeriesOption extends interface SeriesEncodeOptionMixin .
Misc
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information