feat(gauge): axisLabel support angle rotating. close 15944 #16985
Conversation
|
Thanks for your contribution! |
|
Wow looks great! |
src/chart/gauge/GaugeSeries.ts
Outdated
| @@ -172,6 +172,7 @@ export interface GaugeSeriesOption extends SeriesOption<GaugeStateOption, GaugeS | |||
|
|
|||
| axisLabel?: LabelOption & { | |||
| formatter?: LabelFormatter | string | |||
| rotating?: boolean | |||
There was a problem hiding this comment.
I would suggest using rotate as the of series[sunburst].label.rotate and instead of using a boolean type, I think it would be more useful to provide the type 'tangential' | 'radial' | number.
There was a problem hiding this comment.
Thanks for the contribution!
Please also fix the lint problems found in the GitHub Actions.
I don‘t know why eslint config doesn't work in webstorm.
When running npm run lint:fix manually, nothing happen.
done. @Ovilia |
|
@Ovilia |
| verticalAlign: 'middle', | ||
| align: 'center' |
There was a problem hiding this comment.
I think you did an excellent job! This feature is really helpful!
Current implementation looks great. I only have a little doubt about text alignment. It doesn't look very obvious but if you look carefully, you should find that it may not be sufficient to use verticalAlign: 'middle', align: 'center'.
As you can see from this example, the text is aligned to center but in most situations, we may wish to align them to the inner side (which means align to right for text on the left side, and left on the right) or to the outter side vice versa.
But I think we can make this a new feature in another PR by providing new options as align and verticalAlign if you are interested or when some developers ask for such a feature. So I will approve this PR for now.
|
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
|
@MeetzhDing Please also help make a document PR to echarts-doc at the |
doc(gauge): axisLabel support rotate apache/echarts#16985
Brief Information
This pull request is in the type of:
What does this PR do?
gauge text label rotate. #15944
Details
Before: What was the problem?
gauge text label can`t rotating by angle.
After: How is it fixed in this PR?
add new option:
gauge-series.axisLabel.rotatingif true, rotating label by angle.
Misc
Related test cases or examples to use the new APIs
gauge-case.html
gauge-simple.html