Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(View): View center supports string #16904

Merged
merged 7 commits into from
May 1, 2022
Merged

feat(View): View center supports string #16904

merged 7 commits into from
May 1, 2022

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Apr 18, 2022 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

View center option support string

Fixed issues

Details

Before: What was the problem?

Kapture 2022-04-18 at 22 48 32

After: How is it fixed in this PR?

Kapture 2022-04-18 at 23 08 03

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 18, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@susiwen8 susiwen8 changed the title fix(graph): roam center don't support string feat(View): View center suuport string Apr 20, 2022
pissang
pissang reviewed Apr 21, 2022
View reviewed changes
src/coord/View.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang April 21, 2022 13:56
@plainheart plainheart changed the title feat(View): View center suuport string feat(View): View center supports string Apr 21, 2022
@susiwen8 susiwen8 requested a review from pissang April 24, 2022 09:03
@pissang pissang added this to the 5.3.3 milestone Apr 28, 2022
pissang
pissang reviewed Apr 28, 2022
View reviewed changes
src/coord/View.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang April 28, 2022 14:07
pissang
pissang approved these changes Apr 30, 2022
View reviewed changes
Copy link
Contributor

@pissang pissang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @plainheart any more suggestions?

@susiwen8 susiwen8 merged commit bc64125 into apache:master May 1, 2022
@echarts-bot
Copy link

echarts-bot bot commented May 1, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the graphe-roam branch May 1, 2022 10:00
@Ovilia Ovilia added PR: doc ready PR: awaiting doc Document changes is required for this PR. and removed PR: doc ready labels Jun 13, 2022
Ovilia added a commit to apache/echarts-doc that referenced this pull request Jun 13, 2022
@Ovilia
feat(doc): add doc for apache/echarts#16904
94e98e0
@Ovilia Ovilia added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

@100pah 100pah Awaiting requested review from 100pah

@plainheart plainheart Awaiting requested review from plainheart

Assignees
No one assigned
Labels
PR: author is committer PR: doc ready size/M
Projects
None yet
Milestone
5.3.3
Development

Successfully merging this pull request may close these issues.

type graph roam nodes disapper!
4 participants
@susiwen8 @pissang @plainheart @Ovilia