-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sankey): sankey
support edgeLabel
#16767
Conversation
Thanks for your contribution! The pull request is marked to be |
@pissang It's there anything else you need to leave a review for this PR |
Any more suggestion? @pissang @plainheart |
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
@pissang Any suggestion for this feature? |
Waiting for this feature. |
Sorry for missing this PR. LGTM now |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Has this feature release? I set "edgeLabel" in sankey is not work |
@Tiramisupxl Not yet. This feature is included in v5.4.1, which is under the voting process. |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
Details
Before: What was the problem?
Sankey
don't have label on edgesAfter: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
test/sankey-depth.html
Others
Merging options
Other information