Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sankey): sankey support edgeLabel #16767

Merged
merged 4 commits into from
Oct 16, 2022
Merged

feat(sankey): sankey support edgeLabel #16767

merged 4 commits into from
Oct 16, 2022

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Mar 29, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

Sankey don't have label on edges

Screen Shot 2022-03-29 at 11 18 24 PM

After: How is it fixed in this PR?

Screen Shot 2022-03-29 at 11 18 36 PM

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

test/sankey-depth.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 29, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

src/chart/sankey/SankeyView.ts Show resolved Hide resolved
src/chart/sankey/SankeyView.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang March 30, 2022 12:40
@susiwen8
Copy link
Contributor Author

@pissang It's there anything else you need to leave a review for this PR

@susiwen8 susiwen8 requested a review from pissang May 2, 2022 04:41
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 2, 2022
@susiwen8
Copy link
Contributor Author

susiwen8 commented May 5, 2022

Any more suggestion? @pissang @plainheart

@echarts-bot
Copy link

echarts-bot bot commented Jun 29, 2022

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@susiwen8
Copy link
Contributor Author

@pissang Any suggestion for this feature?

@Ovilia Ovilia modified the milestones: 5.4, 5.4.1 Sep 1, 2022
@Nemecsek
Copy link

Waiting for this feature.

@pissang
Copy link
Contributor

pissang commented Oct 16, 2022

Sorry for missing this PR. LGTM now

@pissang pissang merged commit 79dffe6 into apache:master Oct 16, 2022
@echarts-bot
Copy link

echarts-bot bot commented Oct 16, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Tiramisupxl
Copy link

Has this feature release? I set "edgeLabel" in sankey is not work

@plainheart
Copy link
Member

@Tiramisupxl Not yet. This feature is included in v5.4.1, which is under the voting process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants