Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(heatmap): avoid the unexpected gaps when dpr is not an integer #16714

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix some gaps will occur in the heatmap when dpr is not an integer.

Fixed issues

Details

Before: What was the problem?

There are unexpected obvious gaps when dpr is not an integer.

After: How is it fixed in this PR?

Add extra 0.5px for each cell.

Comparison

Before After
image image
image image

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

  • test/heatmap-gap-bug.html
  • test/heatmap-large.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 21, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang
Copy link
Contributor

pissang commented Mar 22, 2022

Just for curious, why the previous Math.floor and Math.round didn't fix it well

@plainheart
Copy link
Member Author

plainheart commented Mar 22, 2022

why the previous Math.floor and Math.round didn't fix it well

I'm not quite sure but I guess it might be because some decimals are unexpectedly rounded up/down. And except for adding an extra half-pixel, I have no better idea for dealing with it.

@pissang
Copy link
Contributor

pissang commented Mar 22, 2022

The result looks good enough so far.

@plainheart plainheart merged commit 5c9430c into master Mar 22, 2022
@plainheart plainheart deleted the fix-heatmap-gap branch March 22, 2022 08:03
@echarts-bot
Copy link

echarts-bot bot commented Mar 22, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants