fix(OrdinalScale): fix line graph renders null value incorrectly. clo… #16672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…se #16664
Brief Information
This pull request is in the type of: bug fixing
What does this PR do?
Fix function OrdinalScale.parse returns an unexpected value
0
withnull
.Fixed issues
Details
Before: What was the problem?
When options like this:
We expect the value of
![image](https://user-images.githubusercontent.com/59865992/158060140-1ab6bad8-8b95-417c-9d0f-6ee1dd4e291b.png)
null
will not be rendered,but ECharts renders it like the following:
When
OrdinalScale.parse
function handle the input value ofnull
,it returns
0
rather thanNaN
,because
Math.round(null)
will produce0
.We expect
null
will behave the same asundefined
.So I add a judgement in
OrdinalScale.parse
.After: How is it fixed in this PR?