Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event): provide label index in axis events #16187

Merged
merged 4 commits into from
Feb 28, 2022
Merged

feat(event): provide label index in axis events #16187

merged 4 commits into from
Feb 28, 2022

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Dec 8, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Provides label index and formatted label in axis label events.

Fixed issues

#15798

Details

Before: What was the problem?

No index info, so the user cannot be sure about which label of the axis is clicked.

After: How is it fixed in this PR?

Two params are provided: index for label index and formattedLabel for formatted label.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@Ovilia Ovilia added this to the 5.3 milestone Dec 8, 2021
@echarts-bot
Copy link

echarts-bot bot commented Dec 8, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: author is committer PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Dec 8, 2021
@Ovilia Ovilia linked an issue Dec 8, 2021 that may be closed by this pull request
@Ovilia Ovilia changed the title fix(event): provide label index in axis events feat(event): provide label index in axis events Dec 8, 2021
andrewchoi5
andrewchoi5 previously approved these changes Jan 11, 2022
@pissang pissang modified the milestones: 5.3, 5.3.1 Feb 28, 2022
@Ovilia Ovilia merged commit fdf5490 into master Feb 28, 2022
@Ovilia Ovilia deleted the fix-15798 branch February 28, 2022 03:47
@echarts-bot
Copy link

echarts-bot bot commented Feb 28, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia removed PR: awaiting doc Document changes is required for this PR. labels Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event data missing on axis label click
3 participants