Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lines): fix NPE issue when lines series has no coordinate system. #16184

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixes #14991 - The lines chart doesn't work and throws the following errors when it has no coordinate system.

TypeError: Cannot read properties of undefined (reading 'dataToPoint')

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/lines-graph.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 8, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang
Copy link
Contributor

pissang commented Jan 4, 2022

Will it be better to give an error message that lines series must have a coordinate system?

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jan 4, 2022
@pissang pissang merged commit 1ba97fc into next Jan 4, 2022
@pissang pissang deleted the fix-lines-NPE branch January 4, 2022 07:42
@echarts-bot
Copy link

echarts-bot bot commented Jan 4, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'dataToPoint' of undefined
2 participants