fix(axis): fix charts render abnormally when yAxis.max is set to be a value less than the min value of the series data.
#15878
Conversation
|
Thanks for your contribution! The pull request is marked to be |
…alue less than the min value of the series data.
plainheart
force-pushed
the
fix-yaxis-max
branch
from
052d8ce
to
309849b
Compare
| @@ -201,11 +201,6 @@ export class ScaleRawExtentInfo { | |||
| (min == null || !isFinite(min)) && (min = NaN); | |||
| (max == null || !isFinite(max)) && (max = NaN); | |||
|
|
|||
| if (min > max) { | |||
| min = NaN; | |||
| max = NaN; | |||
There was a problem hiding this comment.
This change looks good in the example. Are there any concerns at the time we adding this logic @100pah
There was a problem hiding this comment.
#15910 seems to state another potential enhancement where min is identical to max.
There was a problem hiding this comment.
Just consider that if min is set to be bigger than max, it does not make sense to display the chart.
There was a problem hiding this comment.
I agree. But the NaN value brought an unexpected behavior. Maybe it's not a good idea to change here.
There was a problem hiding this comment.
I think we can remove NaN logic here. Then think about how should we handle the case when min/max are invalid.
There was a problem hiding this comment.
@100pah So should we merge this PR and keep improving in further PRs?
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
In ECharts 5.x, the line/bar chart renders abnormally when
yAxis.maxis set to be a value less than the min value of the series data. See #14812 for more details.I'm not sure if the root cause was found. Related commit is b116faa in PR #12832.
Fixed issues
yAxis.maxis set to be a value less than the min value of the series data. #14812Details
Before: What was the problem?
After: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
Please refer to
test/axis-filter-extent2.htmlOthers
Merging options
Other information