[fix] [type]: improve option types #15696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
Ovilia
approved these changes
Sep 9, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
|
Been struggling with typing renderItem last week. Thanks for your great work! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
This PR aimed to improve option types found during the work of rewriting example code with TypeScript. It includes:
renderItemof custom series.CustomSeriesRenderItem,CustomSeriesRenderItemParams,CustomSeriesRenderItemAPI,CustomSeriesRenderItemReturnaxis.type.itemStyle.colorTypescript error on using callback for itemStyle.color #14279emphasis,blur,selectisanyin some series.