Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format #15686

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

100pah
Copy link
Member

@100pah 100pah commented Sep 7, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format.

Fixed issues

Fix #15675 .

Details

Before: What was the problem?

MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format.

It brought by #15355,
where

const dataCtors = {
    'float': CtorFloat64Array,
    'int': CtorInt32Array,
    'ordinal': Array,
    'number': Array,
    // original time is Array, not changed to TypedArray.
    'time': CtorFloat64Array
} as const;

After: How is it fixed in this PR?

Displayed as before.

@echarts-bot
Copy link

echarts-bot bot commented Sep 7, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@100pah 100pah merged commit babc67d into master Sep 7, 2021
@echarts-bot
Copy link

echarts-bot bot commented Sep 7, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line chart - vertical marklines not showing in 5.2 (working in 5.1.2)
2 participants