fix(tooltip): tooltip should show DOM content instead of the string [object HTMLSpanElement] #15313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g [object HTMLSpanElement], resolves #15307. 2) feat(tooltip): formatter can be HTMLElement. (only string/HTMLElement array previously) 3) chore(tooltip): don't show arrow when empty.
|
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
echarts-bot
bot
added
PR: author is committer
PR: awaiting doc
pissang
approved these changes
Jul 15, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix(tooltip): tooltip should show DOM content instead of the string [object HTMLSpanElement], resolves Tooltip formatter doesn't renders HTMLElement if tooltip position is 'top', 'left', 'bottom', 'right', 'inside'. #15307.
fix(tooltip): should clear the DOM content if user-specified content is null, resolves report a problem, that is the tooltip of type map. #14832. Related previous commit: 3ddb125
feat(tooltip): formatter can be HTMLElement. (only string/HTMLElement array previously)
chore(tooltip): don't show arrow when empty.
Fixed issues
Details
Before: What was the problem?
Tooltip shows
[object HTMLSpanElement]instead of expected DOM content.Tooltip doesn't hide when content is null.
After: How is it fixed in this PR?
Tooltip shows DOM content instead of the string
[object HTMLSpanElement]Hide tooltip when content is null
Misc
Tooltip formatted now accepts single HTMLElement.
Related test cases or examples to use the new APIs
Please refer to
test/tooltip-domnode.htmland #14832.Others
Merging options
Other information