Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): there is no polarIndex when coordinate of series is polar #15281

Merged

Conversation

Map1en
Copy link
Member

@Map1en Map1en commented Jul 2, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

添加一个类型

Fixed issues

close #15197

Details

Before: What was the problem?

#15197

After: How is it fixed in this PR?

在SeriesOnPolarOptionMixin添加了类型polarIndex?: number

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 2, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang
Copy link
Contributor

pissang commented Jul 8, 2021

Thanks for the fix! polarId is also missing. Perhaps we can add it to this PR. Also the original radiusAxisIndex, angleAxisIndex, radiusAxisId, angleAxisId seems to be a mistake and should be removed.

@pissang pissang added this to the 5.2 milestone Jul 8, 2021
@Map1en
Copy link
Member Author

Map1en commented Jul 8, 2021

Thanks for the fix! polarId is also missing. Perhaps we can add it to this PR. Also the original radiusAxisIndex, angleAxisIndex, radiusAxisId, angleAxisId seems to be a mistake and should be removed.

已修改

@pissang pissang merged commit d5a7424 into apache:master Jul 8, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 8, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Map1en Map1en deleted the fix-type-polarIndex-when-coord-is-polar branch July 8, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type BarSeriesOption doesn's have polarId options
2 participants