Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sankey): fix dragger bug for sankey when series data key name is nodes #15199

Merged
merged 2 commits into from
Jun 21, 2021
Merged

fix(sankey): fix dragger bug for sankey when series data key name is nodes #15199

merged 2 commits into from
Jun 21, 2021

Conversation

DuLinRain
Copy link
Contributor

@DuLinRain DuLinRain commented Jun 21, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix dragger bug for sankey when series data key name is nodes。

in the no fixed version, when series data key name is "nodes"(which is supported according to official docs), the draggable effect is only applied to nodes, and the node is splited from edges

Fixed issues

fix dragger bug for sankey when series data key name is nodes。

Details

when series data key name is "nodes"(which is supported according to official docs), the draggable effect is only applied to nodes, and the node is splited from edges

Before: What was the problem?

in the no fixed version, when series data key name is "nodes"(which is supported according to official docs), the draggable effect is only applied to nodes, and the node is splited from edges

https://raw.githubusercontent.com/DuLinRain/pictures/master/echarts/sankey.png

After: How is it fixed in this PR?

    const nodes = this.option.data || this.option.nodes;        
    const dataItem = nodes[dataIndex];

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

fix dragger bug for sankey when series data key name is nodes
add test case for sankey chart of the case when series data key name is nodes。

in the no fixed version, when series data key name is "nodes"(which is supported according to official docs), the draggable effect is only applied to nodes, and the node is splited from edges
@echarts-bot
Copy link

echarts-bot bot commented Jun 21, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. and removed PR: awaiting doc Document changes is required for this PR. labels Jun 21, 2021
@pissang pissang added this to the 5.2 milestone Jun 21, 2021
@pissang pissang merged commit 42a97cc into apache:master Jun 21, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jun 21, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants