feat(tree): add tree path info to tooltip #14957
Merged
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
pissang
reviewed
May 17, 2021
src/chart/tree/TreeSeries.ts
Outdated
| } | ||
|
|
||
| interface TreeSeriesCallbackDataParams extends CallbackDataParams { | ||
| treePathInfo?: TreePathInfo[] |
There was a problem hiding this comment.
Ignore the fact that the internal method has been named wrapTreePathInfo, is it better to call this property treeAncestors when providing to developers? path can be from an arbitrary node to another arbitrary node.
There was a problem hiding this comment.
Agreed. Thanks for the suggestion.
pissang
approved these changes
May 18, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Add tree path info to the tooltip as Treemap.
Fixed issues
Fixes #8800
Details
Before: What was the problem?
The path of the tooltip cannot be customized
After: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
tree-basic.html
Others
Merging options
Other information