Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed LineEndLabelOption.valueAnimation to be optional. #14806

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Bilge
Copy link
Contributor

@Bilge Bilge commented Apr 26, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Changes series: {endLabel: {valueAnimation: bool}} to be optional, so valueAnimation does not have to be specified every time endLabel is specified.

Fixed issues

Cannot specify endLabel: {} without TS error:

TS2741: Property 'valueAnimation' is missing in type '{}' but required in type 'LineEndLabelOption'.

@echarts-bot
Copy link

echarts-bot bot commented Apr 26, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 5.1.2 milestone Apr 27, 2021
@pissang pissang merged commit 2790425 into apache:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants