Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geo): fix tooltip don't show on geo component. #14767

Closed
wants to merge 4 commits into from
Closed

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Apr 23, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Default to show tooltip on geo component.

This is because in 5.1.0 geo component enabled tooltip for supporting SVG but set show to false by default. Which will cause all series using this geo component don't show tooltip by default.

  1. Fix the wrong usage of setState in the map. Which may have unexpected error logs(only log, not throw an exception).
  2. Update package-lock.json to avoid CI failure.

@pissang pissang added this to the 5.1.1 milestone Apr 23, 2021
@echarts-bot
Copy link

echarts-bot bot commented Apr 23, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant