Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(marker): add missing type for symbolOffset, fix symbolOffset & symbolKeepAspect doesn't work in markPoint. #14737

Merged
merged 6 commits into from
Jul 7, 2021
Merged

fix(marker): add missing type for symbolOffset, fix symbolOffset & symbolKeepAspect doesn't work in markPoint. #14737

merged 6 commits into from
Jul 7, 2021

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Apr 21, 2021 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Enhance #14375

  • add missing value type string | number to symbolOffset
  • add missing return type string | number to SymbolOffsetCallback
  • fix symbolOffset & symbolKeepAspect doesn't work in markPoint
  • fix symbolOffset type issue in SilderTimelineView
  • extract normalizeSymbolSize & normalizeSymbolOffset to the common symbol util.

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@plainheart
fix(markPoint): symbolOffset & symbolKeepAspect doesn't work in MarkP…
03fd554 
…oint.

- current callback function logic seems inappropriate, data item should not support callback. refactor needed.
@plainheart
fix(MarkerLine): add missing value type string | number to `symbolO…
ad05359 
…ffset` and add missing return type `string | number` to `SymbolOffsetCallback`.
@echarts-bot
Copy link

echarts-bot bot commented Apr 21, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart
Copy link
Member Author

Currently, the logic about parsing symbolOffset with numberUtil.parsePercent and symbolSize is used in many places. I'm thinking to extract it into a common helper to reduce redundant code and bundled size.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 22, 2021
@plainheart plainheart marked this pull request as draft April 22, 2021 01:58
@plainheart plainheart marked this pull request as ready for review April 22, 2021 02:29
@pissang pissang added this to the 5.2.0 milestone Apr 22, 2021
@PiterYang
Copy link

when can publish a new version for this merge ?

@plainheart plainheart mentioned this pull request Apr 26, 2021
Closed
@plainheart plainheart linked an issue Apr 26, 2021 that may be closed by this pull request
markPoint的symbolOffset属性在5.0.2版本里不生效 #14787
Closed
@plainheart plainheart mentioned this pull request Apr 27, 2021
Closed
Ovilia
Ovilia reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ovilia
Copy link
Contributor

Ovilia commented Apr 29, 2021

when can publish a new version for this merge ?

@PiterYang This PR is set to be in 5.2.0, which should be released in about a month.

@plainheart plainheart mentioned this pull request May 2, 2021
Closed
This was linked to issues May 2, 2021
series-line.markPoint. symbolOffset #14854
Closed
Echart5.1.0 markPoint symbolOffset don't work #14816
Closed
@packjie
Copy link

packjie commented Jun 8, 2021 •
edited
Loading

I encountered the same problem. After upgrading the version, markpoint fell down. After checking, I found that the value of symboloffset did not work.
image
After reading this post, I changed the original file
1、node_ modules/echarts/lib/component/marker/MarkPointView.js
image
image
The problem was solved and the chart returned to normal
image

@pissang pissang merged commit cc473b8 into master Jul 7, 2021
@pissang pissang deleted the fix-marker branch July 7, 2021 10:05
@echarts-bot
Copy link

echarts-bot bot commented Jul 7, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@osgregs
Copy link

osgregs commented Jul 7, 2021

ty, waiting new version.

@Flourad
Copy link

Flourad commented Jul 12, 2021

求问下这个特性什么时候能发布呀？

@alanhu151
Copy link

when can publish a new version for this merge ?

@PiterYang This PR is set to be in 5.2.0, which should be released in about a month.

When the 5.2.0 will be released? checked everyday for months. :(

This was referenced Aug 9, 2021
Closed
Closed
@plainheart plainheart mentioned this pull request Aug 10, 2021
Closed
@plainheart plainheart mentioned this pull request Aug 25, 2021
Closed
@dignfei dignfei mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia left review comments

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer priority: high size/L
Projects
None yet
Milestone
5.2
8 participants
@plainheart @PiterYang @Ovilia @packjie @osgregs @Flourad @alanhu151 @pissang