Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): the position of tooltip may be incorrect if appendToBody. #14713

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

The position may be incorrect if appendToBody is enabled, resolves #14710.

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

test/new-tooltip.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 19, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart changed the title fix(tooltip): the position of tooltip may be not incorrect if appendToBody. fix(tooltip): the position of tooltip may be incorrect if appendToBody. Apr 19, 2021
@pissang pissang added this to the 5.1.1 milestone Apr 20, 2021
@pissang pissang requested review from 100pah and susiwen8 April 20, 2021 03:25
@pissang pissang merged commit a8c88a2 into master Apr 20, 2021
@echarts-bot
Copy link

echarts-bot bot commented Apr 20, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-tooltip branch April 20, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.1.0 tooltip位置计算错误
2 participants