Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animation): add animaiton configuration in resize #14553

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Mar 30, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add animation config in ECharts#resize

Fixed issues

#13923

Details

Before: What was the problem?

Resize animation is removed by default in 5.0

After: How is it fixed in this PR?

Add a config so animation can still be enabled when resizing.

Usage

Are there any API changes?

  • The API has been changed.
interface ResizeOpts {
  // other exists opts.
  
  animation: {
     duration: number
     easing: AnimationEasing
     delay: number
  }
}

Related test cases or examples to use the new APIs

myChart.resize({
  animation: {
      duration: 300,
      easing: 'cubicInOut'
  }
});

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 30, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@pissang pissang merged commit ba3e89b into master Mar 30, 2021
@pissang pissang deleted the resize-animation branch March 30, 2021 06:35
@echarts-bot
Copy link

echarts-bot bot commented Mar 30, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants