feat(legend): make default legend more intuitive #14497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the |
echarts-bot
bot
added
PR: author is committer
PR: awaiting doc
plainheart
reviewed
Mar 26, 2021
Ovilia
changed the title
pissang
approved these changes
Apr 7, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Ovilia
added a commit
to apache/echarts-doc
that referenced
this pull request
Apr 21, 2021
pissang
added a commit
to apache/echarts-doc
that referenced
this pull request
Apr 21, 2021
doc: more intuitive legend apache/echarts#14497
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Update default legend style so that the icons looks more intuitively like that of the series.
Fixed issues
Details
Before: What was the problem?
Legend for line series only have the color of the series, lacking
itemStyle.borderWidth,itemStyle.borderColor,lineStyle.color,lineStyle.borderColorand etc.After: How is it fixed in this PR?
Legend for line series looks more like that of the series.
emptyCirclehas been changed tocircle.See
test/legend-style.htmlfor more info.Usage
Are there any API changes?
Related test cases or examples to use the new APIs
test/legend-style.htmlOthers
Merging options
Other information
There was a PR #12444 before v5.0 and there was too much to be merged so I made this new PR based on v5.0 code base.