Add LegendComponentOption.icon property type #14263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
nihilates
approved these changes
Feb 11, 2021
marcinja
approved these changes
Feb 11, 2021
dominic-farquharson
approved these changes
Feb 12, 2021
pissang
approved these changes
Feb 17, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
adds the icon property to LegendComponentOption
Fixed issues
#14262
Details
Before: What was the problem?
couldn't add a strongly typed legend option object because the icon property didn't exist
After: How is it fixed in this PR?
add the type for it
Usage
Are there any API changes?
Updates the TS types to be in line with the echarts docs https://echarts.apache.org/en/option.html#legend.icon
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information