Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Calendar): fix day label drifting. close #11508 #13902

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

Nick22nd
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix day label drifting

Fixed issues

Details

Before: What was the problem?

If orient is horizontal and range changes, the cell will automatically adjust its width.
But the weekly text margin always to be 50% width of cellSize.

issue

After: How is it fixed in this PR?

I tried to fix it by making daylabel margin always be the cell's height .

fixed

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 29, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang
Copy link
Contributor

pissang commented Mar 30, 2021

Sorry for the late review. Is it better to use the smaller dimension like:

margin = numberUtil.parsePercent(margin, Math.min(cellSize[1], cellSize[0]);

Since cellSize[1] may also be too large when calendar layout is vertical

@pissang pissang merged commit a7fe5a4 into apache:master Mar 30, 2021
@echarts-bot
Copy link

echarts-bot bot commented Mar 30, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants