-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JoinSelection Rule to choose physical join implementation: HashJoin(Partitioned or CollectLeft) or SortMergeJoin base on Stats #4139
Comments
@alamb @andygrove @isidentical @Dandandan @yahoNanJing The basic idea is if one of side(left or right) is small enough(threshold on size or row count, for example 10M), will choose HashJoin:CollectLeft. Please share your thoughts. |
Sounds like a good plan. For hash join, probably needs some benchmarking to figure out good defaults and avoid performance degradation. |
I agree with @Dandandan that doing some benchmarking on sort merge join is likely a good idea. I don't think we have much at the moment as it is never used. What I think would be an ideal solution, though maybe harder to implement, is to NOT decide between has or sort merge join at plan time, but to decide at runtime So that would involve starting out using HashJoin but if the hash table spilled (or exceeded some size threshold) sort/spill it and then switch to sort-merge-join |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: