From b367a2de41fd5078030889739c73503084f1eb2e Mon Sep 17 00:00:00 2001
From: Nick Vatamaniuc <vatamane@gmail.com>
Date: Fri, 26 Apr 2024 12:40:55 -0400
Subject: [PATCH] Improve fabric all_dbs test

Previously I forgot to assert we actually created the dbs and forgot to clean
them up. Also, add a few more cases using a wider variety of delimiters.
---
 src/fabric/test/eunit/fabric_tests.erl | 51 ++++++++++++++++++++------
 1 file changed, 40 insertions(+), 11 deletions(-)

diff --git a/src/fabric/test/eunit/fabric_tests.erl b/src/fabric/test/eunit/fabric_tests.erl
index 16a7c6bb2a..0b3f20a462 100644
--- a/src/fabric/test/eunit/fabric_tests.erl
+++ b/src/fabric/test/eunit/fabric_tests.erl
@@ -316,24 +316,53 @@ fabric_all_dbs_test_() ->
     }.
 
 t_get_all_dbs(_) ->
-    Db1 = <<"a">>,
-    Db2 = <<"b">>,
-    Db3 = <<"a/b">>,
-    [fabric:create_db(Db) || Db <- [Db1, Db2, Db3]],
-    ?assertEqual({ok, [<<"a">>, <<"a/b">>, <<"b">>]}, fabric:all_dbs()).
+    DbList = [<<"aaa">>, <<"a+b">>, <<"a$c">>, <<"aaa/bbb">>],
+    ?assertEqual(ok, create_dbs(DbList)),
+    ExpectList = lists:sort(DbList),
+    ?assertEqual({ok, ExpectList}, fabric:all_dbs()),
+    ?assertEqual(ok, delete_dbs(DbList)).
 
 t_prefix_works(_) ->
-    DbList = ["a0", "a", "aa", "ab", "aa/", "a//a", "a/b", "a/"],
-    [fabric:create_db(list_to_binary(Db)) || Db <- DbList],
+    DbList = [
+        "aaa0",
+        "aaa+",
+        "aaa(",
+        "aa",
+        "a",
+        "aaaa",
+        "aaa/y",
+        "aaa/x",
+        "aaa/x$",
+        "aaa/x/z",
+        "aaa$"
+    ],
+    ?assertEqual(ok, create_dbs(DbList)),
     AllExpect = lists:sort([list_to_binary(Db) || Db <- DbList]),
     ?assertEqual({ok, AllExpect}, fabric:all_dbs()),
     ?assertEqual({ok, AllExpect}, fabric:all_dbs(<<>>)),
+    ?assertEqual({ok, []}, fabric:all_dbs(<<"$">>)),
     ?assertEqual({ok, []}, fabric:all_dbs(<<"b">>)),
-    ?assertEqual({ok, [<<"a/">>, <<"a//a">>, <<"a/b">>]}, fabric:all_dbs(<<"a/">>)),
-    ?assertEqual({ok, [<<"a0">>]}, fabric:all_dbs(<<"a0">>)),
-    ?assertEqual({ok, []}, fabric:all_dbs(<<"/">>)),
     ?assertEqual({ok, AllExpect}, fabric:all_dbs(<<"a">>)),
-    ?assertEqual({ok, [<<"aa">>, <<"aa/">>]}, fabric:all_dbs(<<"aa">>)).
+    ?assertEqual({ok, AllExpect -- [<<"a">>, <<"aa">>]}, fabric:all_dbs(<<"aaa">>)),
+    ?assertEqual({ok, [<<"aaa0">>]}, fabric:all_dbs(<<"aaa0">>)),
+    ?assertEqual({ok, [<<"aaa+">>]}, fabric:all_dbs(<<"aaa+">>)),
+    ?assertEqual({ok, [<<"aaa(">>]}, fabric:all_dbs(<<"aaa(">>)),
+    ?assertEqual({ok, [<<"aaaa">>]}, fabric:all_dbs(<<"aaaa">>)),
+    ?assertEqual({ok, [<<"aaa/x$">>]}, fabric:all_dbs(<<"aaa/x$">>)),
+    ?assertEqual({ok, [<<"aaa/x">>, <<"aaa/x$">>, <<"aaa/x/z">>]}, fabric:all_dbs(<<"aaa/x">>)),
+    ?assertEqual({ok, [<<"aaa/x/z">>]}, fabric:all_dbs(<<"aaa/x/z">>)),
+    ?assertEqual({ok, [<<"aaa/x/z">>]}, fabric:all_dbs(<<"aaa/x/">>)),
+    TripleASlash = lists:sort([<<"aaa/x">>, <<"aaa/y">>, <<"aaa/x$">>, <<"aaa/x/z">>]),
+    ?assertEqual({ok, TripleASlash}, fabric:all_dbs(<<"aaa/">>)),
+    ?assertEqual(ok, delete_dbs(DbList)).
+
+create_dbs(DbList) ->
+    Fun = fun(DbName) -> ok = fabric:create_db(DbName) end,
+    lists:foreach(Fun, DbList).
+
+delete_dbs(DbList) ->
+    Fun = fun(DbName) -> ok = fabric:delete_db(DbName) end,
+    lists:foreach(Fun, DbList).
 
 setup_fabric() ->
     Ctx = test_util:start_couch([fabric]),