Fix seedlist to not return duplicate json keys #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydoane
approved these changes
Apr 3, 2024
rnewson
approved these changes
Apr 3, 2024
|
I'll add a few tests for the success path. Would have to mock the internal replicator we don't have a multi-node test framework. |
b944695
to
e30c37c
Compare
Previously, we used `lists:ukeymerge` which only works if the entries in the list are kept in a sorted order, but they weren't. Since we now have maps available in Erlang, use those instead of proplists which would avoid the sorting issue. While at it, make sure to test the `_up` and `_uuids` "misc" handler endpoints and modernize the seedlist test suite as well.
e30c37c
to
36f034d
Compare
|
Coverage looks a bit better: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used lists:ukeymerge which only works if the entries in the list are kept in a sorted order but they weren't. Since we now have maps, use those instead of proplists which would avoid the sorting issue.
While at it, make sure to test the _up and _uuids "misc" handler endpoints and modernize the seedlist test suite as well.
Fix: #5009