Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequent flaky failure in ddoc_cache tests #4793

Closed
nickva opened this issue Oct 4, 2023 · 0 comments · Fixed by #4803
Closed

Frequent flaky failure in ddoc_cache tests #4793

nickva opened this issue Oct 4, 2023 · 0 comments · Fixed by #4803
Labels

Comments

@nickva
Copy link
Contributor

nickva commented Oct 4, 2023

The current top flaky failures are from ddoc_cache.

[2023-10-04T15:25:31.519Z] module 'ddoc_cache_lru_test'
[2023-10-04T15:25:31.519Z]   ddoc_cache_lru_test: check_not_started_test...ok
[2023-10-04T15:25:31.519Z]   ddoc_cache_lru_test:99: with (check_multi_start)...[0.011 s] ok
[2023-10-04T15:25:31.519Z]   ddoc_cache_lru_test:99: with (check_multi_open)...[0.002 s] ok
[2023-10-04T15:25:32.265Z]   ddoc_cache_lru_test:99: with (check_capped_size)...[0.486 s] ok
[2023-10-04T15:25:33.998Z]   ddoc_cache_lru_test:99: with (check_cache_refill)...*failed*
[2023-10-04T15:25:33.998Z] in function meck_proc:wait/6 (src/meck_proc.erl, line 171)
[2023-10-04T15:25:33.998Z] in call from ddoc_cache_lru_test:check_cache_refill/1 (test/eunit/ddoc_cache_lru_test.erl, line 206)
[2023-10-04T15:25:33.998Z] in call from eunit_test:run_testfun/1 (eunit_test.erl, line 71)
[2023-10-04T15:25:33.998Z] in call from eunit_proc:run_test/1 (eunit_proc.erl, line 531)
[2023-10-04T15:25:33.998Z] in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 356)
[2023-10-04T15:25:33.998Z] in call from eunit_proc:handle_test/2 (eunit_proc.erl, line 514)
[2023-10-04T15:25:33.998Z] in call from eunit_proc:tests_inorder/3 (eunit_proc.erl, line 456)
[2023-10-04T15:25:33.998Z] in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 346)
[2023-10-04T15:25:33.998Z] **error:timeout
[2023-10-04T15:25:33.998Z]   output:<<"">>
[2023-10-04T15:25:33.998Z] 
nickva added a commit that referenced this issue Oct 6, 2023
This test has been the most flaky one lately.

DDoc cache does quite a bit async process spawning. It's possible that entry
processes never finish opening before the test already proceeds and expects all
10 entries to be removed.

Also, to increase isolation between tests switch eunit `setup` to `foreach`.
This will restart the whole ddoc app and reduce possible influence of one test
on another.

Fix: #4793
nickva added a commit that referenced this issue Oct 6, 2023
This test has been the most flaky one lately.

DDoc cache does quite a bit async process spawning. It's possible that entry
processes never finish opening before the test already proceeds and expects all
10 entries to be removed.

Also, to increase isolation between tests switch eunit `setup` to `foreach`.
This will restart the whole ddoc app and reduce possible influence of one test
on another.

Fix: #4793
nickva added a commit that referenced this issue Oct 6, 2023
This test has been the most flaky one lately.

DDoc cache does quite a bit async process spawning. It's possible that entry
processes never finish opening before the test already proceeds and expects all
10 entries to be removed.

Also, to increase isolation between tests switch eunit `setup` to `foreach`.
This will restart the whole ddoc app and reduce possible influence of one test
on another.

Fix: #4793
nickva added a commit that referenced this issue Oct 6, 2023
This test has been the most flaky one lately.

DDoc cache does quite a bit async process spawning. It's possible that entry
processes never finish opening before the test already proceeds and expects all
10 entries to be removed.

Also, to increase isolation between tests switch eunit `setup` to `foreach`.
This will restart the whole ddoc app and reduce possible influence of one test
on another.

Fix: #4793
@pgj pgj removed the needs-triage label Oct 6, 2023
rnewson pushed a commit that referenced this issue Oct 24, 2023
This test has been the most flaky one lately.

DDoc cache does quite a bit async process spawning. It's possible that entry
processes never finish opening before the test already proceeds and expects all
10 entries to be removed.

Also, to increase isolation between tests switch eunit `setup` to `foreach`.
This will restart the whole ddoc app and reduce possible influence of one test
on another.

Fix: #4793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants