Another attempt at fixing the flaky ddoc_cache test #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
force-pushed
the
fix-ddoc-cache-flakiness
branch
from
49e0836
to
a789b38
Compare
jaydoane
approved these changes
Oct 6, 2023
This test has been the most flaky one lately. DDoc cache does quite a bit async process spawning. It's possible that entry processes never finish opening before the test already proceeds and expects all 10 entries to be removed. Also, to increase isolation between tests switch eunit `setup` to `foreach`. This will restart the whole ddoc app and reduce possible influence of one test on another. Fix: #4793
nickva
force-pushed
the
fix-ddoc-cache-flakiness
branch
from
a789b38
to
0eb2899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been the most flaky one lately.
DDoc cache does quite a bit async process spawning. It's possible that entry processes never finish opening before the test already proceeds and expects all 10 entries to be removed.
Also, to increase isolation between tests switch eunit
setuptoforeach. This will restart the whole ddoc app and reduce possible influence of one test on another.Fix: #4793