Fix badrecord error when replicator is logging http usage #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
approved these changes
Sep 14, 2023
nickva
force-pushed
the
fix-replicator-http-check-for-transient-replications
branch
from
fab3e62
to
3431d51
Compare
jaydoane
reviewed
Sep 14, 2023
nickva
force-pushed
the
fix-replicator-http-check-for-transient-replications
branch
from
3431d51
to
d57b65b
Compare
jaydoane
approved these changes
Sep 14, 2023
Previously when transient replication jobs were canceled their `#rep` record's source and target fields would be `undefined`. That was accounted for in the http usage logger when it's enabled and resulted in a badrecord 500 error. Fix: #4760
nickva
force-pushed
the
fix-replicator-http-check-for-transient-replications
branch
from
d57b65b
to
4e79e6a
Compare
nickva
deleted the
fix-replicator-http-check-for-transient-replications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when transient replication jobs were canceled their
#reprecord's source and target fields would beundefined. That was accounted for in the http usage logger when it's enabled and resulted in a badrecord 500 error.Fix: #4760