-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate various elixir makefile targets #3824
Comments
Some things I learned:
|
IRC |
That makes sense @iilyak , thanks. I filed a PR in #3831 a few days ago to drive some improvements but didn't touch the basic Option 1: Ignore suite.elixir if skip.elixir is emptyIf we did this then anyone not relying on a Option 2: Dynamically generate suite.elixir content if skip.elixir is usedWith this approach no one needs to maintain Option 3: Exclude tests by nameI discovered that the module and test name are automatically injected as tags on each test. That means we could exclude tests by name using the existing skip.elixir format, but we'd have to take care to ensure globally-unique test names (today we have some identically-named tests across modules). No one need maintain |
Reopen to continue discussion of additional improvements. |
We settled on |
Summary
If anyone is interested in consolidating the elixir, elixir-only, and elixir-suite into a single target I'm all ears. The first two are identical save for the
MIX_ENV
andCOUCHDB_TEST_ADMIN_PARTY_OVERRIDE
environment settings, so I'm guessing we only need one target. The last one uses a skip file instead of the@pending
tag; I'm not sure we need two distinct approaches there.Desired Behaviour
A simpler, more obvious Makefile
Additional context
Originally reported in #3818
The text was updated successfully, but these errors were encountered: