Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually validate admin username/password in Windows installer #2543

Open
wohali opened this issue Feb 13, 2020 · 0 comments
Open

Actually validate admin username/password in Windows installer #2543

wohali opened this issue Feb 13, 2020 · 0 comments

Comments

@wohali
Copy link
Member

wohali commented Feb 13, 2020

Summary

The new CouchDB 3.0 Windows installer now prompts for an admin username and password at install time. #2263 and #2188 mean CouchDB won't handle usernames or passwords with certain special characters in them. The installer doesn't prevent this.

Desired Behaviour

Actually detect that this occurs during installer prompt time and don't allow to progress if bad chars are found in username or password.

Possible Solution

Use the StringTools WiX extension from https://github.com/dblock/msiext (EPL 1.0) to check. It isn't hard but I ran out of time before the 3.0 installer had to ship.

Additional context

It'd prevent surprises in a pretty small number of cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant