Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of esprima.js and escodegen.js #2372

Open
1 of 5 tasks
jiangphcn opened this issue Dec 18, 2019 · 2 comments
Open
1 of 5 tasks

Keep track of esprima.js and escodegen.js #2372

jiangphcn opened this issue Dec 18, 2019 · 2 comments

Comments

@jiangphcn
Copy link
Contributor

jiangphcn commented Dec 18, 2019

Summary

esprima.js and escodegen.js are introduced to support spidermonkey 6.0 porting in CouchDB, especially supporting the traditional CouchDB-style function declaration.

"map": "function(doc) {emit(doc._id, doc._id);}"

They are being maintained under [1] https://github.com/jquery/esprima and [2] https://github.com/estools/escodegen

In planned CouchDB 3.0, we are using the variant from [3] https://github.com/dmunch/couch-chakra.

Desired Behaviour

We need to better keep track of evolution of esprima and escodegen.

Possible Solution

  • create couch-esprima and couch-escodegen repositories so that there are safe copy
  • compare the difference between [1] [2] and [3]
  • find tools/scripts build workable version from couch-esprima and couch-escodegen
  • figure out the way how to apply patch for CouchDB 3.0
  • define and implement how to continuously apply fixes and improvement from [1] and [2] for CouchDB.

Additional context

@janl @garrensmith @davisp @wohali

@wohali
Copy link
Member

wohali commented Mar 13, 2020

@jiangphcn Any chance of working on this one? I don't want to let this get forgotten.

@wohali wohali added chore and removed needs-triage labels Mar 13, 2020
@jiangphcn
Copy link
Contributor Author

thanks @wohali for checking out. I will follow up in coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants