Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Windows build #1449

Closed
wohali opened this issue Jul 17, 2018 · 5 comments
Closed

Fix the Windows build #1449

wohali opened this issue Jul 17, 2018 · 5 comments
Milestone
2.2.0

Comments

@wohali
Copy link
Member

wohali commented Jul 17, 2018

#1346 broke the build for Windows.

  • rebar.config for hyper needs updating
  • there are C99-isms in hyper_carray.c that fail as well as attempts at pointer arithmetic on a void *
@wohali wohali added this to the 2.2.0 milestone Jul 17, 2018
@wohali wohali mentioned this issue Jul 18, 2018
Closed
@janl
Copy link
Member

janl commented Jul 18, 2018

what needs doing here? cc @davisp @kocolosk

@wohali
Copy link
Member Author

wohali commented Jul 18, 2018

Partially addressed by apache/couchdb-hyper#4

Turns out bcrypt won't compile now, that's the next step.

@wohali
Copy link
Member Author

wohali commented Jul 18, 2018

#1456 will fix the hyper issue.

Backing bcrypt out of master with +1s from @rnewson and @janl, see #1160 (comment)

@wohali
Copy link
Member Author

wohali commented Jul 18, 2018

bcrypt has been removed, now this is holding things up:

apache/couchdb-fauxton#1105

/cc @popojargo @Antonio-Maranhao

@wohali
Copy link
Member Author

wohali commented Jul 18, 2018

Building without Fauxton, all CouchDB tests now pass. \o/

@wohali wohali closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@janl @wohali