Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for crashes in commit_compaction_data #1263

Open
iilyak opened this issue Apr 3, 2018 · 0 comments
Open

Add logging for crashes in commit_compaction_data #1263

iilyak opened this issue Apr 3, 2018 · 0 comments

Comments

@iilyak
Copy link
Contributor

iilyak commented Apr 3, 2018

Crash in commit_compaction_data causes severe issues. However it is quite hard to figure out what shard it was crashed on. We need to add logging to log shard name in case of a crash in the critical function.

Expected Behavior

When commit_compaction_data crashes for any reason we should see a message in the log which contains the shard name.

Current Behavior

There is a crash dump which doesn't contain any useful information to identify problematic shard.

Possible Solution

Add try/catch and log from the catch

Steps to Reproduce (for bugs)

See https://github.com/apache/couchdb/pull/1255/files#diff-b6c880ef1513b1db939914f94786a1a5

Context

Your Environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant