Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests utility belt #1232

Open
eiri opened this issue Mar 23, 2018 · 1 comment
Open

Extend tests utility belt #1232

eiri opened this issue Mar 23, 2018 · 1 comment

Comments

@eiri
Copy link
Member

eiri commented Mar 23, 2018

It's be nice to have some standard test wrapper with 'retry until' or 'pass if any of N' functionality to deal with things like:

Compact after lowering attachment size limit couchdb_attachments_tests:544: should_compact_after_lowering_attachment_size_limit...*failed*

in function couchdb_attachments_tests:wait_compaction/3 (test/couchdb_attachments_tests.erl, line 586)
in call from couchdb_attachments_tests:compact_db/1 (test/couchdb_attachments_tests.erl, line 573)
in call from couchdb_attachments_tests:'-should_compact_after_lowering_attachment_size_limit/1-fun-1-'/1 (test/couchdb_attachments_tests.erl, line 550)

**error:{assertion_failed,[{module,couchdb_attachments_tests}, {line,573},
{reason,"Timeout waiting for database database compaction"}]}
  output:<<"">>
@janl
Copy link
Member

janl commented Mar 28, 2018

@eiri problem is eunit standard timeouts. So even if we do a spinloop of “do until success”, we’d run into the eunit timeout. We can raise that of course, but we’ll be doing that a lot.

Maybe there is a way to set a timeout globally and set it to really long for travis and jenkins runs, so we never run into them™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants