Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider eliminating known-slow requests from request_time stats/histogram #1116

Open
wohali opened this issue Jan 17, 2018 · 0 comments
Open

Comments

@wohali
Copy link
Member

wohali commented Jan 17, 2018

Ran into this with a client recently. Here's what we do right now:

https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd.erl#L353-L354

But it might be nice to ignore specific types of requests that are known to run long, that will skew the histogram/averages, such as:

  • /_replicate
  • any DB and global changes feeds with continuous or longpoll options

We could also relegate these to a separate "long request" histogram stats bucket.

/cc @janl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant