add service.labels and fix ingress service reference #95
Conversation
|
@colearendt can you describe how you envisage |
Well, it might be desirable just to document why there are two and what their respective purpose is. Been looking in many places for this. As for this PR, @colearendt , I suspect it will have an easier life if it would leave out the |
|
@willholley Totally missed your approval here, sorry about that! That's a fantastic question. I will fix the merge conflict. I suspect there are ways to automate the NEWS.md, but the way that I usually do it is just on each PR:
This creates potential for merge conflicts, but in practice has worked pretty well 🤷♂️ . I'm definitely happy to help draft contributing docs if that'd be useful! |
The ingress was mistakenly pointed to the headless service required for maintaining the statefulset. This means that `service.annotations`, etc. were not useful for controlling ingress behavior. It might be desirable to change service names at some point to indicate which is headless / internal. However, that could be a disruptive action to any existing environments.
colearendt
force-pushed
the
fix-service-issue
branch
from
bcd6db7
to
5b5f558
Compare
|
@willholley this is ready to merge 😄 |
What this PR does / why we need it:
The ingress was mistakenly pointed to the headless service required for maintaining the statefulset. This means that
service.annotations, etc. were not useful for controlling ingress behavior.It might be desirable to change service names at some point to indicate which is headless / internal. However, that could be a disruptive action to any existing environments.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.