Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: fixes wrong Values iteration in ingress host #8

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Bugfix: fixes wrong Values iteration in ingress host #8

merged 1 commit into from
Nov 1, 2019

Conversation

arjun-1
Copy link

@arjun-1 arjun-1 commented Nov 1, 2019 •
edited
Loading

What this PR does / why we need it:

#6 introduced configurable path, but we cannot use .Values within an iteration in Helm. It resulted in an error like:

Error: render error in "couchdb/templates/ingress.yaml": template: couchdb/templates/ingress.yaml:23:28: executing "couchdb/templates/ingress.yaml" at <.Values.ingress.path>: can't evaluate field Values in type interface {}

Fixes #9

Checklist

  • Chart Version bumped
  • e2e tests pass
  • Variables are documented in the README.md
  • Chart tgz added to /docs and index updated

@arjun-1 arjun-1 mentioned this pull request Nov 1, 2019
Closed
@willholley willholley merged commit f2d5661 into apache:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willholley willholley willholley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong use of .Values in ingress
3 participants
@arjun-1 @willholley @arjundhawan-tomtom