Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-install hook job should also run post-upgrade #133

Open
thndrbrrr opened this issue Dec 9, 2023 · 0 comments
Open

post-install hook job should also run post-upgrade #133

thndrbrrr opened this issue Dec 9, 2023 · 0 comments

Comments

@thndrbrrr
Copy link

The post-install job in templates/job.yaml is only executed when CouchDB is installed, but not when it is upgraded. This is problematic when CouchDB is used as a subchart but not installed initially due to a dependency condition.

Version of Helm and Kubernetes:

Helm: 3.13.2
Kubernetes: 1.28.3

What happened:

Background: CouchDB is declared as a dependency in a parent chart with the condition couchdb.enabled.

When initially installing the parent chart with couchdb.enabled=false, and then later upgrading the parent chart with couchdb.enabled=true, the post-install hook job is not run, and therefore cluster setup is not completed as expected (with autoSetup.enabled=true).

Which makes sense in a way because helm install != helm upgrade, but what I'm saying is that the job should also be run when CouchDB is added as part of an upgrade.

What you expected to happen:

Since autoSetup.enabled was set to true, it should have finalized the CouchDB cluster setup.

How to reproduce it (as minimally and precisely as possible):

  1. Declare CouchDB as a subchart with a condition:
dependencies:
  - name: couchdb
    version: 4.4.5
    repository: https://apache.github.io/couchdb-helm
    condition: couchdb.enabled
  1. Install parent chart with helm install ... --set couchdb.enabled=false.
  2. Upgrade parent chart with helm install ... --wait --set couchdb.enabled=true.

Anything else we need to know:

This is easily fixed by changing the job's annotation to

annotations:
    "helm.sh/hook": post-install,post-upgrade

Happy to provide a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant