-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extraconfig parameter unable to be set via Domain Admin #9397
Comments
@scottsignal refer to cloudstack/api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java Lines 144 to 145 in afdf4d7
it has |
we could remove the restriction, as the extraconfig is allowed when deploy a vm |
Unless there is good reason to not. At a minimum, it would be nice to allow that not to be hard coded and be able to select roles to be selected in global settings for additional roles to add additional extraconfig. Thanks! |
I agree with @scottsignal - also there are global settings which can restrict the passing of the extra configs to the hypervisor side even though the extra configs are defined as VM settings: |
Ok, so we can change the hard-coding to allow access to the parameter for all and "just" check the global settings during the call, right @nvazquez ? |
Yes @DaanHoogland - the access is already in place using these configurations as far as I know so only editing the access should work |
fixed in #9422 |
ISSUE TYPE
COMPONENT NAME
CLOUDSTACK VERSION
CONFIGURATION
Ubuntu 22.04
KVM
OS / ENVIRONMENT
N/A
SUMMARY
A user in an account with the default out of the box role "Domain Admin" is unable to add the extraconfig parameter via API. Running this same API command as Root Admin works just fine.
STEPS TO REPRODUCE
Ensure that the 2 options are set and reboot mgmt:
allow.additional.vm.configuration.list.kvm = backend, tpm, devices
Enable additional vm configuration = enabled
Build an account & user with the out of the box role "Domain Admin"
Build an instance normally, however, make sure the Start Instance ratio is unselected at the bottom.
Run the API command to modify add the extra config. Running this command does not work under an account with out of the box default "Domain Admin" role.
EXPECTED RESULTS
extraconfig added to the VM.
ACTUAL RESULTS
API returns results with no error, however, extraconfig is not added.
The text was updated successfully, but these errors were encountered: