Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using arrow_schema in downcast_dictionary_array #5676

Closed
jayzhan211 opened this issue Apr 22, 2024 · 2 comments
Closed

Avoid using arrow_schema in downcast_dictionary_array #5676

jayzhan211 opened this issue Apr 22, 2024 · 2 comments
Labels
question Further information is requested

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Apr 22, 2024 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I found that I need to import arrow-schema for this macro although I have imported arrow already. I expect to call this macro with arrow::array:: without import arrow-schema. I think changing the prefix of Datatype solves this problem

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@jayzhan211 jayzhan211 added the enhancement Any new improvement worthy of a entry in the changelog label Apr 22, 2024
@tustvold
Copy link
Contributor

This would break usage for people who don't wish to take a dependency on arrow, only arrow-array, I'm not sure there is a way around this...

@jayzhan211
Copy link
Contributor Author

This would break usage for people who don't wish to take a dependency on arrow, only arrow-array, I'm not sure there is a way around this...

I see, agree with it.

@tustvold tustvold added question Further information is requested and removed enhancement Any new improvement worthy of a entry in the changelog labels Apr 23, 2024
@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@jayzhan211 jayzhan211 mentioned this issue May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tustvold @jayzhan211