Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filter in filter_leaves API propagate error #5574

Closed
viirya opened this issue Mar 31, 2024 · 1 comment · Fixed by #5575
Closed

Make filter in filter_leaves API propagate error #5574

viirya opened this issue Mar 31, 2024 · 1 comment · Fixed by #5575
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Mar 31, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently filter_leaves API takes a closure which returns a bool. In some cases, e.g., apache/iceberg-rust#245 (comment), we may like to propagate error from it.

Describe the solution you'd like

Changing the filter in filter_leaves to return Result<bool>.

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Mar 31, 2024
@viirya viirya mentioned this issue Mar 31, 2024
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Apr 17, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add try_filter_leaves to propagate error from filter closure viirya/arrow-rs
2 participants
@viirya @tustvold