Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringViewArray implementation and layout and basic construction + tests #5469

Closed
Tracked by #5374
alamb opened this issue Mar 4, 2024 · 5 comments · Fixed by #5481
Closed
Tracked by #5374

Add StringViewArray implementation and layout and basic construction + tests #5469

alamb opened this issue Mar 4, 2024 · 5 comments · Fixed by #5481
Assignees
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Mar 4, 2024

This is part of the larger project to implement StringViewArray -- see #5374

After #5468 we will next need to implement StringViewArray

For inspiration I think you can look at #4585

(specifically arrow-array/src/array/byte_view_array.rs https://github.com/apache/arrow-rs/pull/4585/files#diff-160ecd8082d5d28081f01cdb08a898cb8f49b17149c7118bf96746ddaae24b4f)

Basic tasks:

  1. CreateUtf8ViewArray and implement Array for it. This should follow the outline from Add StringViewArray and BinaryViewArray (#4253) #4585 and implement a similar API to StringArray https://docs.rs/arrow/latest/arrow/array/type.StringArray.html
  2. Add documentaton for new array, with documentation
  3. Examples of constructing the array in docs
  4. Tests for basic creation APIs (like new() and new_unchecked, value(), is_null() etc).

Potentially: implement pretty printing for Utf8ViewArray via ArrayFormatter, though this could be done as a separate ticket / PR.

@alamb alamb changed the title Array implementations and layout and basic construction Add Utf8ViewArray and BinaryViewArrayimplementations and layout and basic construction Mar 4, 2024
@alamb alamb changed the title Add Utf8ViewArray and BinaryViewArrayimplementations and layout and basic construction Add Utf8ViewArray implementation and layout and basic construction Mar 4, 2024
@alamb alamb changed the title Add Utf8ViewArray implementation and layout and basic construction Add Utf8ViewArray implementation and layout and basic construction + tests Mar 4, 2024
@alamb alamb changed the title Add Utf8ViewArray implementation and layout and basic construction + tests Add StringViewArray implementation and layout and basic construction + tests Mar 4, 2024
@ariesdevil
Copy link
Contributor

Please assign me, thx :)

@alamb
Copy link
Contributor Author

alamb commented Mar 5, 2024

I plan to merge #5470 later today -- I don't expect substantial changes, so if you would like to start on this issue, you could probably make a branch from #5470 and rebase once we merge that

@alamb
Copy link
Contributor Author

alamb commented Mar 5, 2024

Noce that #5470 is merged I think this ticket is unblocked and ready to go

Note I think this ticket will be somewhat of a bottleneck. Once it is done I think we can start implementing other features in parallel (like IPC support, cast, filter, etc)

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5481

@tustvold tustvold added the parquet Changes to the parquet crate label Mar 15, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'parquet'} from #4585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
3 participants