Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate enabling features in regex crate to reduce compile times #51

Open
alamb opened this issue Apr 26, 2021 · 1 comment
Open
Labels
arrow Changes to the arrow crate

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-6482

The regex crate recently added a feature flag to reduce compile times and binary size if certain unicode related features are not needed.  We should investigate using this feature.

@alamb alamb added the arrow Changes to the arrow crate label Apr 26, 2021
@alamb
Copy link
Contributor Author

alamb commented Apr 26, 2021

Comment from Krisztian Szucs(kszucs) @ 2019-09-17T11:47:55.906+0000:

[~paddyhoran] may we postpone this after 0.15?

Comment from Paddy Horan(paddyhoran) @ 2019-09-18T02:25:23.049+0000:

Yep, will change.

Comment from Neville Dipale(nevi_me) @ 2020-06-01T11:31:39.865+0000:

[~paddyhoran] I've briefly looked at this, and it seems like the only feature we'd want to remove would be Unicode support ([https://docs.rs/regex/1.3.9/regex/#crate-features]). 

Comment from Paddy Horan(paddyhoran) @ 2020-06-01T15:05:34.773+0000:

Yep, it's the unicode features I had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

No branches or pull requests

1 participant