[arrow-row] add offsets at the Row level
#4848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a user to more easily extract the encoded data for a single value for the row format.
judahrand
force-pushed
the
row-format-offsets
branch
from
aa5ce52
to
59008f8
Compare
|
I'm not really sure about this, as written it will double the memory usage for many use-cases, and I expect this to similarly regress encodd performance. Perhaps we could take a step back here and start with your intended use-case for this functionality? The ticket mentions some notion of storing data by cell, but I'm not following why this can't be achieved by simply iterating the values in an array (column) |
|
Marking this as a draft to indicate it isn't waiting on review, feel free to unmark when you would like me to take another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4847
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?