-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use optimized implementation of bloom filter #4213
Labels
enhancement
Any new improvement worthy of a entry in the changelog
Comments
Do you have any performance benchmark results you could share? |
I added it to the benchmarks here: crepererum-oss/pdatastructs.rs#126. |
@tustvold added benchmark against I ran it on an aarch64 cpu and these are the results I get:
couldn't bench the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey!
I implemented https://github.com/ozgrakkurt/sbbf-rs.
It is an implementation of parquet bloom filters, I checked it against the implementation at
parquet2
and it produces same output.I would like to integrate it here if it makes sense to do.
A big problem with it may be that it has different implementations including a
aarch64::neon
which wouldn't get tested on GitHub CI.The text was updated successfully, but these errors were encountered: