Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(object_store) Update ring to latest version to fix win-64 builds #3829

Closed
chitralverma opened this issue Mar 9, 2023 · 1 comment
Closed
Labels

Comments

@chitralverma
Copy link

chitralverma commented Mar 9, 2023

Describe the bug
object_store uses ring for signatures and cryptography but ring has issues building on windows 64bit arch.

So any project which cross-compiles and is using object_store as a dependency will have a build failure on win64 builds.

This is a issue for tracking progress of the upgrade as ring itself is yet to publish a fix for this in an upcoming release.

To Reproduce
Create a project with object_store as dependency and cargo build it for aarch64-pc-windows-msvc target.

See example of a failed build at the link below,
https://github.com/chitralverma/test-native-proj/actions/runs/4373382006

Expected behavior
The build should not break.

Additional context
More context and discussion at the link below,
briansmith/ring#1167

@tustvold
Copy link
Contributor

Closed by #4887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants